Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the maximum number of lines for the clear command #7911

Merged
merged 1 commit into from
May 31, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

If it is not limited, if the user specifies a very large value (such as 999999999), it will cause a large number of data packets to be sent, and the java heap size is prompted under the mac, and the cmd window directly under my win is forced to close
dang

mac:
image

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #7911 (7c558ba) into master (e845e16) will increase coverage by 0.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7911      +/-   ##
============================================
+ Coverage     59.28%   60.27%   +0.99%     
- Complexity      529      546      +17     
============================================
  Files          1077     1089      +12     
  Lines         43565    43852     +287     
  Branches       6368     6402      +34     
============================================
+ Hits          25826    26432     +606     
+ Misses        14879    14466     -413     
- Partials       2860     2954      +94     
Impacted Files Coverage Δ
...ing/telnet/support/command/ClearTelnetHandler.java 100.00% <100.00%> (ø)
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) ⬇️
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 61.53% <0.00%> (-8.03%) ⬇️
...bbo/config/bootstrap/builders/ConsumerBuilder.java 93.10% <0.00%> (-6.90%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.34% <0.00%> (-6.84%) ⬇️
...apache/dubbo/rpc/cluster/support/ClusterUtils.java 60.00% <0.00%> (-6.04%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 72.22% <0.00%> (-5.56%) ⬇️
.../threadpool/manager/DefaultExecutorRepository.java 80.95% <0.00%> (-4.54%) ⬇️
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...7c558ba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants