Extract constants in RegistryProtocol (#7727)

apache · May 11, 2021 · e845e16 · e845e16
1 parent 200f06e
commit e845e16
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/...bo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java b/...bo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
@@ -131,6 +131,9 @@ public class RegistryProtocol implements Protocol {
             APPLICATION_KEY, VERSION_KEY, GROUP_KEY, DUBBO_VERSION_KEY, RELEASE_KEY
     };
 
+    private final static String REGISTRY_PROTOCOL_LISTENER_KEY = "registry.protocol.listener";
+    private final static int DEFAULT_PORT = 9090;
+
     private final static Logger LOGGER = LoggerFactory.getLogger(RegistryProtocol.class);
     private final Map<URL, NotifyListener> overrideListeners = new ConcurrentHashMap<>();
     private final Map<String, ServiceConfigurationListener> serviceConfigurationListeners = new ConcurrentHashMap<>();
@@ -143,7 +146,9 @@ public class RegistryProtocol implements Protocol {
     protected ProxyFactory proxyFactory;
 
     private ConcurrentMap<URL, ReExportTask> reExportFailedTasks = new ConcurrentHashMap<>();
-    private HashedWheelTimer retryTimer = new HashedWheelTimer(new NamedThreadFactory("DubboReexportTimer", true), DEFAULT_REGISTRY_RETRY_PERIOD, TimeUnit.MILLISECONDS, 128);
+    private HashedWheelTimer retryTimer =
+            new HashedWheelTimer(new NamedThreadFactory("DubboReexportTimer", true), DEFAULT_REGISTRY_RETRY_PERIOD, TimeUnit.MILLISECONDS,
+                    128);
 
     // get the parameters which shouldn't been displayed in url string(Starting with .)
     private static String[] getHiddenKeys(URL url) {
@@ -171,7 +176,7 @@ public void setProxyFactory(ProxyFactory proxyFactory) {
 
     @Override
     public int getDefaultPort() {
-        return 9090;
+        return DEFAULT_PORT;
     }
 
     public Map<URL, NotifyListener> getOverrideListeners() {
@@ -231,7 +236,7 @@ public <T> Exporter<T> export(final Invoker<T> originInvoker) throws RpcExceptio
 
     private <T> void notifyExport(ExporterChangeableWrapper<T> exporter) {
         List<RegistryProtocolListener> listeners = ExtensionLoader.getExtensionLoader(RegistryProtocolListener.class)
-                .getActivateExtension(exporter.getOriginInvoker().getUrl(), "registry.protocol.listener");
+                .getActivateExtension(exporter.getOriginInvoker().getUrl(), REGISTRY_PROTOCOL_LISTENER_KEY);
         if (CollectionUtils.isNotEmpty(listeners)) {
             for (RegistryProtocolListener listener : listeners) {
                 listener.onExport(this, exporter);
@@ -301,7 +306,8 @@ public <T> void reExport(final Invoker<T> originInvoker, URL newInvokerUrl) {
                 oldTask = reExportFailedTasks.putIfAbsent(registeredUrl, task);
                 if (oldTask == null) {
                     // never has a retry task. then start a new task for retry.
-                    retryTimer.newTimeout(task, registryUrl.getParameter(REGISTRY_RETRY_PERIOD_KEY, DEFAULT_REGISTRY_RETRY_PERIOD), TimeUnit.MILLISECONDS);
+                    retryTimer.newTimeout(task, registryUrl.getParameter(REGISTRY_RETRY_PERIOD_KEY, DEFAULT_REGISTRY_RETRY_PERIOD),
+                            TimeUnit.MILLISECONDS);
                 }
             }
         }
@@ -476,7 +482,8 @@ protected <T> Invoker<T> doRefer(Cluster cluster, Registry registry, Class<T> ty
         return interceptInvoker(migrationInvoker, url, consumerUrl);
     }
 
-    protected <T> ClusterInvoker<T> getMigrationInvoker(RegistryProtocol registryProtocol, Cluster cluster, Registry registry, Class<T> type, URL url, URL consumerUrl) {
+    protected <T> ClusterInvoker<T> getMigrationInvoker(RegistryProtocol registryProtocol, Cluster cluster, Registry registry,
+                                                        Class<T> type, URL url, URL consumerUrl) {
         return new ServiceDiscoveryMigrationInvoker<T>(registryProtocol, cluster, registry, type, url, consumerUrl);
     }
 
@@ -535,7 +542,7 @@ public static URL toSubscribeUrl(URL url) {
 
     protected List<RegistryProtocolListener> findRegistryProtocolListeners(URL url) {
         return ExtensionLoader.getExtensionLoader(RegistryProtocolListener.class)
-                .getActivateExtension(url, "registry.protocol.listener");
+                .getActivateExtension(url, REGISTRY_PROTOCOL_LISTENER_KEY);
     }
 
     // available to test