Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeat operations in ConsumerContextClusterInterceptor #7821

Merged
merged 2 commits into from
May 22, 2021

Conversation

BurningCN
Copy link
Member

These operations of a already exist in ConsumerContextFilter, so remove the duplicate code of ConsumerContextClusterInterceptor

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #7821 (16f9d33) into master (e845e16) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7821      +/-   ##
============================================
- Coverage     59.28%   59.09%   -0.19%     
- Complexity      529      556      +27     
============================================
  Files          1077     1086       +9     
  Lines         43565    43798     +233     
  Branches       6368     6390      +22     
============================================
+ Hits          25826    25882      +56     
- Misses        14879    15045     +166     
- Partials       2860     2871      +11     
Impacted Files Coverage Δ Complexity Δ
...interceptor/ConsumerContextClusterInterceptor.java 80.00% <ø> (-3.34%) 0.00 <0.00> (ø)
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 28.35% <0.00%> (-50.75%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-20.69%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 43.47% <0.00%> (-19.57%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 78.63% <0.00%> (-8.55%) 0.00% <0.00%> (ø%)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...16f9d33. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 442f083 into apache:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants