Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the doUnsubscribe method to remove elements from related containers #7804

Merged
merged 1 commit into from
May 22, 2021

Conversation

BurningCN
Copy link
Member

Optimize the doUnsubscribe method to remove elements from related containers

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #7804 (63c327d) into master (e845e16) will increase coverage by 0.15%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7804      +/-   ##
============================================
+ Coverage     59.28%   59.43%   +0.15%     
- Complexity      529      556      +27     
============================================
  Files          1077     1086       +9     
  Lines         43565    43804     +239     
  Branches       6368     6393      +25     
============================================
+ Hits          25826    26036     +210     
- Misses        14879    14898      +19     
- Partials       2860     2870      +10     
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 60.24% <66.66%> (-0.13%) 0.00 <0.00> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 61.53% <0.00%> (-8.03%) 0.00% <0.00%> (ø%)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 49.45% <0.00%> (-4.40%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 37.70% <0.00%> (-3.37%) 0.00% <0.00%> (ø%)
...ain/java/org/apache/dubbo/config/MethodConfig.java 95.65% <0.00%> (-3.09%) 0.00% <0.00%> (ø%)
...fig/configcenter/TreePathDynamicConfiguration.java 77.14% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...63c327d. Read the comment docs.

@AlbumenJ AlbumenJ merged commit e4bcb5b into apache:master May 22, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants