Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method annotation callback do not work problem #7754

Merged
merged 4 commits into from
May 15, 2021

Conversation

codeimport
Copy link
Contributor

@codeimport codeimport commented May 13, 2021

What is the purpose of the change

fix #6833 when use method annotation like below,callback method dose not work

@DubboReference(check = false,methods = {@Method(name = "sayHello",oninvoke = "methodCallback.oninvoke",onreturn = "methodCallback.onreturn",onthrow = "methodCallback.onthrow")})
private HelloService helloServiceMethodCallBack;

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #7754 (407ad9f) into master (e845e16) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #7754    +/-   ##
==========================================
  Coverage     59.28%   59.28%            
- Complexity      529      530     +1     
==========================================
  Files          1077     1080     +3     
  Lines         43565    43674   +109     
  Branches       6368     6376     +8     
==========================================
+ Hits          25826    25891    +65     
- Misses        14879    14926    +47     
+ Partials       2860     2857     -3     
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/dubbo/config/MethodConfig.java 95.65% <84.21%> (-3.09%) 0.00 <0.00> (ø)
...beans/factory/annotation/ReferenceBeanBuilder.java 93.44% <100.00%> (+1.44%) 0.00 <0.00> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 82.05% <0.00%> (-5.13%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...fig/configcenter/TreePathDynamicConfiguration.java 77.14% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
.../dubbo/monitor/support/AbstractMonitorFactory.java 78.37% <0.00%> (-2.71%) 0.00% <0.00%> (ø%)
...bo/registry/client/FileSystemServiceDiscovery.java 67.44% <0.00%> (-2.33%) 0.00% <0.00%> (ø%)
...figcenter/file/FileSystemDynamicConfiguration.java 31.42% <0.00%> (-0.96%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/config/ServiceConfig.java 62.71% <0.00%> (-0.36%) 0.00% <0.00%> (ø%)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...407ad9f. Read the comment docs.

@AlbumenJ AlbumenJ merged commit dee7373 into apache:master May 15, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
kylixs pushed a commit to kylixs/dubbo that referenced this pull request Jun 21, 2021
@kylixs kylixs mentioned this pull request Jun 21, 2021
8 tasks
AlbumenJ pushed a commit that referenced this pull request Jun 24, 2021
* Pick method callback test from #7754

* Set default value of MethodConfig fields

* Fix method callback test, change to remote call

* Fix tests

* Tests transaction of callback method

Co-authored-by: chen gang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment