Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RpcInvocation adds returnType assignment in initParameterDesc #7746

Merged
merged 3 commits into from
May 14, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

RpcInvocation adds returnType assignment in initParameterDesc

see more detail from #7745

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

# Conflicts:
#	dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/support/RpcUtilsTest.java
@BurningCN
Copy link
Member

Can this line be deleted?

image

@xiaoheng1
Copy link
Contributor Author

Can this line be deleted?

image

greet! i think this line can be deleted.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #7746 (793eca5) into master (e845e16) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7746      +/-   ##
============================================
- Coverage     59.28%   59.15%   -0.13%     
  Complexity      529      529              
============================================
  Files          1077     1080       +3     
  Lines         43565    43651      +86     
  Branches       6368     6372       +4     
============================================
- Hits          25826    25823       -3     
- Misses        14879    14973      +94     
+ Partials       2860     2855       -5     
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 64.73% <100.00%> (+0.20%) 0.00 <0.00> (ø)
...ntext/event/AwaitingNonWebApplicationListener.java 48.48% <0.00%> (-24.25%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 86.79% <0.00%> (-5.67%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 82.05% <0.00%> (-5.13%) 0.00% <0.00%> (ø%)
.../dubbo/monitor/support/AbstractMonitorFactory.java 78.37% <0.00%> (-2.71%) 0.00% <0.00%> (ø%)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.61% <0.00%> (-0.40%) 26.00% <0.00%> (-1.00%)
...in/java/org/apache/dubbo/config/ServiceConfig.java 62.71% <0.00%> (-0.36%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (ø) 0.00% <0.00%> (ø%)
...che/dubbo/registry/nacos/NacosRegistryFactory.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...o/registry/nacos/util/NacosNamingServiceUtils.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...793eca5. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 8e4ef09 into apache:master May 14, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants