Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumer side call DefaultExecutorRepository#getExecutor method cannot hit the cache when use the service discovery pattern #7717

Merged
merged 1 commit into from
May 11, 2021

Conversation

BurningCN
Copy link
Member

@BurningCN BurningCN commented May 10, 2021

issue #7718

…annot hit the cache when use the service discovery pattern
@codecov-commenter
Copy link

Codecov Report

Merging #7717 (ae3e8f7) into master (f29663b) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7717      +/-   ##
============================================
- Coverage     59.18%   58.99%   -0.20%     
+ Complexity      529      528       -1     
============================================
  Files          1076     1076              
  Lines         43540    43495      -45     
  Branches       6363     6331      -32     
============================================
- Hits          25771    25660     -111     
- Misses        14903    14974      +71     
+ Partials       2866     2861       -5     
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/registry/client/InstanceAddressURL.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-20.69%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 50.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-11.54%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 76.27% <0.00%> (-10.17%) 0.00% <0.00%> (ø%)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29663b...ae3e8f7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants