Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer side call DefaultExecutorRepository#getExecutor cannot hit the cache when use the service discovery pattern #7718

Closed
BurningCN opened this issue May 10, 2021 · 2 comments
Closed

Consumer side call DefaultExecutorRepository#getExecutor cannot hit the cache when use the service discovery pattern #7718

BurningCN opened this issue May 10, 2021 · 2 comments

Comments

@BurningCN
Copy link
Member

BurningCN commented May 10, 2021 •
edited
Loading

I use the dubbo-samples/dubbo-samples-cloud-native/dubbo-demo-servicediscovery-xml/ test case indubbo-samples project, consumer call DefaultExecutorRepository#createExecutorIfAbsent method is normal, url.getParameter(SIDE_KEY) is consumer, and it's put entry {Integer.MAX_VALUE,executor}into cache . However, when calling the DefaultExecutorRepository#getExecutor method, the url.getParameter(SIDE_KEY) is null,This will make it impossible to use previously cached Executors

image

image
@BurningCN BurningCN mentioned this issue May 10, 2021
Merged
@horizonzy
Copy link
Member

Hi, I want to know it detail, this situation just happen in samples?

@BurningCN
Copy link
Member Author

see #7732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@horizonzy @BurningCN