Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in CommonConstants #6373

Merged
merged 1 commit into from
Jul 1, 2020
Merged

fix typo in CommonConstants #6373

merged 1 commit into from
Jul 1, 2020

Conversation

DangHT
Copy link
Contributor

@DangHT DangHT commented Jun 25, 2020 •
edited
Loading

What is the purpose of the change

Find small typo in CommonConstants.java

dubbo/dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java

Line 115 in 7447f33

String TIMEOUT_ATTACHENT_KEY = "_TO";

dubbo/dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java

Line 123 in 7447f33

String PROPERTIES_CHAR_SEPERATOR = "-";

Brief changelog

  1. Fix typo from TIMEOUT_ATTACHENT_KEY to TIMEOUT_ATTACHMENT_KEY
  2. Fix typo from PROPERTIES_CHAR_SEPERATOR to PROPERTIES_CHAR_SEPARATOR

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@DangHT
Copy link
Contributor Author

DangHT commented Jun 29, 2020

@htynkn PTAL

@chickenlj chickenlj merged commit 41cbb23 into apache:master Jul 1, 2020
@DangHT DangHT deleted the fix-constant-typo branch July 1, 2020 07:19
mercyblitz added a commit that referenced this pull request Jul 2, 2020
@mercyblitz @tswstarplanet
@nineyang @luoning810 @cvictory @chickenlj @DIscord010 @DangHT @skyguard1 @aquariuspj @XiaoWeiKIN @zouyx @OrDTesters @zjseu
2.7.8 release (#6407)
173df9a 
* Polish #6296 : Adding the new methods into MetadataReport to manipulate the exported URLs for service introspection

* Polish #6296 : Adding the new methods into MetadataReport to manipulate the exported URLs for service introspection

* Polish #6171 : [Feature] Introducing the composite implementation of MetadataService

* Revert "fix wrong check of InvokerListener when export a service (fix issue_6269) (#6271)"

This reverts commit 91989ca.

* Revert "fix wrong check of InvokerListener when export a service (fix issue_6269) (#6271)"

This reverts commit 91989ca.

* Revert the MetadataReport

* Polish #6305 : [Refactor] ServiceConfig and ReferenceConfig publish the ServiceDefinition based on the Dubbo Event

* Polish #6198 : [Issue] Fixing NacosDynamicConfiguration#publishConfig bug

* Polish #6310 : Refactoring MetadataReport's methods

* Polish #6198 : [Issue] Fixing NacosDynamicConfiguration#publishConfig bug

* Polish #6198 : [Issue] Fixing NacosDynamicConfiguration#publishConfig bug

* Polish #6315 : [Refactor] Refactoring the implementation of MetadataReport based on The Config-Center infrastructure

Deprecated List :

- NacosMetadataReport
- ZookeeperMetadataReport

* Polish #6315 : Refactoring by TreePathDynamicConfiguration

* Polish #6315 : Refactoring ConsulDynamicConfiguration by TreePathDynamicConfiguration

* Polish #6315 : Reset the config base path to be "metadata" for ConfigCenterBasedMetadataReportFactory

* Polish #6315 : Bugfix

* Polish #6315 : Bugfix

* Polish #6315 : Correct words

* sync wait netty server to finish shutdown (#6281)

* Polish #6333 : [Refactor] Using mandatory implementation of Service Instance registration instead of the event

* maybe we can remove null judge in this case (#6321)

* update

* update

* Polish #6336 : [Refactor] org.apache.dubbo.metadata.ServiceNameMapping

* Polish #6170 : [Feature] Introducing the externalized configuration for ServiceNameMapping

* Polish #6342 : [Enhancement] Introducing the composite ServiceNameMapping

* Refactor

* fix method name typo in JValidator.java (#6344)

* [Dubbo-6340]fix application cannot exit when use consul registry (#6341)

* fix application cannot exit when use consul registry

* make consul registry suppor ACL (#6313)

* make consul registry suppor ACL

* Polish #6172 : [Feature] Adding the "services" attribute methods into @DubboReference

* Polish #6173 : [Feature] Adding the "services" attribute into <dubbo:reference> element

* Polish #6346 : [Issue] Merging all subscribied URLs from the multiple services

* Polish #6346 : [Issue] Merging all subscribied URLs from the multiple services

* fix publish null value when use consul config center (#6351)

* fix publish null value when use consul config center

* Polish #6252

* Polish #6356 & #6171

* Polish #6356 & #6171

* Polish #6224 : Filter chain was not invoked with local calls since v2.7.6

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : Adding META-INF/dubbo/internal/org.apache.dubbo.metadata.MetadataServiceExporter

* fix the priority of ListenableRouter were not effective (#6148)

fixes #4822

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* when the url is generic, the log level should be info (#6363)

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* fix NPE when check=false is set and provider is empty. (#6376)

fixes #6228

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* fix #6306.  support TypeBuilder sort (#6365)

* fix #6306. support TypeBuilder sort

* fix #6306. support TypeBuilder sort

* fix #6306. support TypeBuilder sort

* remove unused import

* add license for test file

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* enhance ClusterInvoker & ExtensionLoader (#6343)

- Introduce ClusterInvoker to better support multiple registries subscription
- Wrapper sort and enable/disable
- some small fixes

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Fixed the test-cases

* Enhancement, support Map auto recognize in PojoUtils (#6106)

Fix #5939

* Polish #6389 : [Issue] Resolving the issues with ConsulServiceDiscovery

* fix typo in CommonConstants (#6373)

* Fix export provider error, change to catch throwable, handle NoClassDefFoundError (#6380)

* check parameterTypesDesc of Generic and Echo  (#6374)

* add tps filter to SPI list (#6282)

* Do not clear all configurator  instances when override is empty (#6395)

* Service callback throws "Not found exported service" when 'bind.port' is set (#6223)

* Removing RpcContext after test finishes. (#6314)

* Introduce ClusterInvoker to better support multiple registries subscription (#6343)

* return same reference invokers as much as possible (#6083)

fixes #6082

* fix ut

* Fixes the test-cases

* Fixes the test-cases

* Fixes the test-cases

Co-authored-by: tswstarplanet <[email protected]>
Co-authored-by: Nine <[email protected]>
Co-authored-by: 陈哈哈 <[email protected]>
Co-authored-by: luoning810 <[email protected]>
Co-authored-by: cvictory <[email protected]>
Co-authored-by: ken.lj <[email protected]>
Co-authored-by: Siqu Chen <[email protected]>
Co-authored-by: D-H-T <[email protected]>
Co-authored-by: skyguard1 <[email protected]>
Co-authored-by: Jeff Lu <[email protected]>
Co-authored-by: Christophe·liwei <[email protected]>
Co-authored-by: Joe Zou <[email protected]>
Co-authored-by: 李黄河 <[email protected]>
Co-authored-by: OrDTesters <[email protected]>
Co-authored-by: zjseu2009 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DangHT @chickenlj