Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-5939] Fix ClassCastException in PojoUtils #6106

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

DIscord010
Copy link
Contributor

What is the purpose of the change

Fix #5939

Brief changelog

Add Key type check.

@mercyblitz mercyblitz requested a review from chickenlj May 6, 2020 08:18
@mercyblitz mercyblitz added this to the 2.7.7 milestone May 6, 2020
@mercyblitz
Copy link
Contributor

LGTM

@hengyunabc hengyunabc modified the milestones: 2.7.7, 2.7.8 May 7, 2020
@DIscord010
Copy link
Contributor Author

@chickenlj Could you help me review this PR when have time?

@chickenlj chickenlj merged commit bbacab0 into apache:master Jun 30, 2020
@DIscord010 DIscord010 deleted the fix_issue#5939 branch July 1, 2020 01:13
mercyblitz added a commit that referenced this pull request Jul 2, 2020
* Polish #6296 : Adding the new methods into MetadataReport to manipulate the exported URLs for service introspection

* Polish #6296 : Adding the new methods into MetadataReport to manipulate the exported URLs for service introspection

* Polish #6171 : [Feature] Introducing the composite implementation of MetadataService

* Revert "fix wrong check of InvokerListener when export a service (fix issue_6269) (#6271)"

This reverts commit 91989ca.

* Revert "fix wrong check of InvokerListener when export a service (fix issue_6269) (#6271)"

This reverts commit 91989ca.

* Revert the MetadataReport

* Polish #6305 : [Refactor] ServiceConfig and ReferenceConfig publish the ServiceDefinition based on the Dubbo Event

* Polish #6198 : [Issue] Fixing NacosDynamicConfiguration#publishConfig bug

* Polish #6310 : Refactoring MetadataReport's methods

* Polish #6198 : [Issue] Fixing NacosDynamicConfiguration#publishConfig bug

* Polish #6198 : [Issue] Fixing NacosDynamicConfiguration#publishConfig bug

* Polish #6315 : [Refactor] Refactoring the implementation of MetadataReport based on The Config-Center infrastructure

Deprecated List :

- NacosMetadataReport
- ZookeeperMetadataReport

* Polish #6315 : Refactoring by TreePathDynamicConfiguration

* Polish #6315 : Refactoring ConsulDynamicConfiguration by TreePathDynamicConfiguration

* Polish #6315 : Reset the config base path to be "metadata" for ConfigCenterBasedMetadataReportFactory

* Polish #6315 : Bugfix

* Polish #6315 : Bugfix

* Polish #6315 : Correct words

* sync wait netty server to finish shutdown (#6281)

* Polish #6333 : [Refactor] Using mandatory implementation of Service Instance registration instead of the event

* maybe we can remove null judge in this case (#6321)

* update

* update

* Polish #6336 : [Refactor] org.apache.dubbo.metadata.ServiceNameMapping

* Polish #6170 : [Feature] Introducing the externalized configuration for ServiceNameMapping

* Polish #6342 : [Enhancement] Introducing the composite ServiceNameMapping

* Refactor

* fix method name typo in JValidator.java (#6344)

* [Dubbo-6340]fix application cannot exit when use consul registry (#6341)

* fix application cannot exit when use consul registry

* make consul registry suppor ACL (#6313)

* make consul registry suppor ACL

* Polish #6172 : [Feature] Adding the "services" attribute methods into @DubboReference

* Polish #6173 : [Feature] Adding the "services" attribute into <dubbo:reference> element

* Polish #6346 : [Issue] Merging all subscribied URLs from the multiple services

* Polish #6346 : [Issue] Merging all subscribied URLs from the multiple services

* fix publish null value when use consul config center (#6351)

* fix publish null value when use consul config center

* Polish #6252

* Polish #6356 & #6171

* Polish #6356 & #6171

* Polish #6224 : Filter chain was not invoked with local calls since v2.7.6

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : Adding META-INF/dubbo/internal/org.apache.dubbo.metadata.MetadataServiceExporter

* fix the priority of ListenableRouter were not effective (#6148)

fixes #4822

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* when the url is generic, the log level should be info (#6363)

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* fix NPE when check=false is set and provider is empty. (#6376)

fixes #6228

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* fix #6306.  support TypeBuilder sort (#6365)

* fix #6306. support TypeBuilder sort

* fix #6306. support TypeBuilder sort

* fix #6306. support TypeBuilder sort

* remove unused import

* add license for test file

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* enhance ClusterInvoker & ExtensionLoader (#6343)

- Introduce ClusterInvoker to better support multiple registries subscription
- Wrapper sort and enable/disable
- some small fixes

* Polish #6322 : [Enhancement] Fix the issues of test-cases after refactoring

* Fixed the test-cases

* Enhancement, support Map auto recognize in PojoUtils (#6106)

Fix #5939

* Polish #6389 : [Issue] Resolving the issues with ConsulServiceDiscovery

* fix typo in CommonConstants (#6373)

* Fix export provider error, change to catch throwable, handle NoClassDefFoundError (#6380)

* check parameterTypesDesc of Generic and Echo  (#6374)

* add tps filter to SPI list (#6282)

* Do not clear all configurator  instances when override is empty (#6395)

* Service callback throws "Not found exported service" when 'bind.port' is set (#6223)

* Removing RpcContext after test finishes. (#6314)

* Introduce ClusterInvoker to better support multiple registries subscription (#6343)

* return same reference invokers as much as possible (#6083)

fixes #6082

* fix ut

* Fixes the test-cases

* Fixes the test-cases

* Fixes the test-cases

Co-authored-by: tswstarplanet <[email protected]>
Co-authored-by: Nine <[email protected]>
Co-authored-by: 陈哈哈 <[email protected]>
Co-authored-by: luoning810 <[email protected]>
Co-authored-by: cvictory <[email protected]>
Co-authored-by: ken.lj <[email protected]>
Co-authored-by: Siqu Chen <[email protected]>
Co-authored-by: D-H-T <[email protected]>
Co-authored-by: skyguard1 <[email protected]>
Co-authored-by: Jeff Lu <[email protected]>
Co-authored-by: Christophe·liwei <[email protected]>
Co-authored-by: Joe Zou <[email protected]>
Co-authored-by: 李黄河 <[email protected]>
Co-authored-by: OrDTesters <[email protected]>
Co-authored-by: zjseu2009 <[email protected]>
@Warkeeper
Copy link

Hi there, sorry for bothering. This solution solved the problem using JDK 8 api, is there something alternatives for JDK 6 so we could backport it to 2.6.* ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

telnet issue
5 participants