Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proto package and java_package issue #13559

Merged
merged 9 commits into from
Dec 26, 2023

Conversation

namelessssssssssss
Copy link
Contributor

@namelessssssssssss namelessssssssssss commented Dec 23, 2023

Fix issue #13496

  • Add provider config useJavaPackageAsPath
  • useJavaPackageAsPath=ture : Provider will export with java_package as path, which will cause exception when package and java_package are different.
  • useJavaPackageAsPath=false (default) : Provider will export with package as path.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e26a22d) 70.39% compared to head (bcdf5e1) 70.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13559      +/-   ##
==========================================
- Coverage   70.39%   70.37%   -0.02%     
==========================================
  Files        1604     1604              
  Lines       69957    69964       +7     
  Branches    10093    10095       +2     
==========================================
- Hits        49246    49240       -6     
- Misses      16082    16092      +10     
- Partials     4629     4632       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
36.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@icodening icodening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 738f3ff into apache:3.2 Dec 26, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants