Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest bugfix & optimization #11617

Merged
merged 9 commits into from
Feb 23, 2023
Merged

Rest bugfix & optimization #11617

merged 9 commits into from
Feb 23, 2023

Conversation

mytang0
Copy link
Member

@mytang0 mytang0 commented Feb 20, 2023 •
edited
Loading

What is the purpose of the change

  1. Modifier/rawtypes/commented redundant code/Constants optimize
  2. Fix consistency bug, issue RestProtocol doRefer consistency bug #11618
  3. Support exception mapper extension

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #11617 (05776e2) into 3.2 (62509fb) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 05776e2 differs from pull request most recent head edf3ed2. Consider uploading reports for the commit edf3ed2 to get more accurate results

@@             Coverage Diff              @@
##                3.2   #11617      +/-   ##
============================================
- Coverage     69.75%   69.61%   -0.15%     
+ Complexity      105        2     -103     
============================================
  Files          1573     1382     -191     
  Lines         84223    59993   -24230     
  Branches      15012     8917    -6095     
============================================
- Hits          58750    41764   -16986     
+ Misses        20573    14087    -6486     
+ Partials       4900     4142     -758
Impacted Files Coverage Δ
...ubbo/rpc/protocol/rest/BaseRestProtocolServer.java
...bbo/rpc/protocol/rest/DubboHttpProtocolServer.java
.../dubbo/rpc/protocol/rest/DubboResourceFactory.java
...bbo/rpc/protocol/rest/NettyRestProtocolServer.java
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java
...che/dubbo/rpc/protocol/rest/RestServerFactory.java
...ache/dubbo/rpc/protocol/rest/RpcContextFilter.java
...he/dubbo/rpc/protocol/rest/RpcExceptionMapper.java
...emoting/transport/ExceedPayloadLimitException.java
.../java/org/apache/dubbo/metrics/model/TimePair.java
... and 2945 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mytang0 mytang0 changed the title Rest model opt Rest model opt & bugfix Feb 22, 2023
@mytang0 mytang0 changed the title Rest model opt & bugfix Rest mode & bugfix & optimization Feb 22, 2023
@mytang0 mytang0 changed the title Rest mode & bugfix & optimization Rest bugfix & optimization Feb 22, 2023
@mytang0
Merge remote-tracking branch 'origin/3.2' into rest
e869c6f 
* origin/3.2:
  Observability task: metadata center (apache#11593)
  Enhance the way to get dubbo version (apache#11574)
  Bump protobuf-java from 3.21.12 to 3.22.0 (apache#11615)
  Bump maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11613)
  Bump micrometer-bom from 1.10.3 to 1.10.4 (apache#11611)
  Bump libthrift from 0.17.0 to 0.18.0 (apache#11614)
  Bump maven-failsafe-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11612)
  Bump reactor-core from 3.5.2 to 3.5.3 (apache#11610)
  Bump byte-buddy from 1.13.0 to 1.14.0 (apache#11609)
  Bump maven-javadoc-plugin from 3.4.1 to 3.5.0 (apache#11608)
  Bump micrometer-tracing-bom from 1.0.1 to 1.0.2 (apache#11607)
  3.2 consumer proxy invocation handler (apache#11108)
  Update DubboReference.java (apache#11621)

# Conflicts:
#	dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/RestProtocol.java
#	dubbo-rpc/dubbo-rpc-rest/src/test/java/org/apache/dubbo/rpc/protocol/rest/JaxrsRestProtocolTest.java
@mytang0
resolve conflict
a65475d
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

67.2% 67.2% Coverage
0.0% 0.0% Duplication

AlbumenJ
AlbumenJ approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit c5a03c9 into apache:3.2 Feb 23, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 23, 2023
@mytang0
Merge remote-tracking branch 'origin/3.2' into refactor-sliding-window
adffd38 
* origin/3.2:
  sync meter to spring boot management (apache#11630)
  Rest bugfix & optimization (apache#11617)
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 23, 2023
@mytang0
Merge remote-tracking branch 'origin/3.2' into service-payload
914b7f5 
* origin/3.2: (32 commits)
  dubbo-security Jackson error (apache#11622)
  sync meter to spring boot management (apache#11630)
  Rest bugfix & optimization (apache#11617)
  Observability task: metadata center (apache#11593)
  Enhance the way to get dubbo version (apache#11574)
  Bump protobuf-java from 3.21.12 to 3.22.0 (apache#11615)
  Bump maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11613)
  Bump micrometer-bom from 1.10.3 to 1.10.4 (apache#11611)
  Bump libthrift from 0.17.0 to 0.18.0 (apache#11614)
  Bump maven-failsafe-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11612)
  Bump reactor-core from 3.5.2 to 3.5.3 (apache#11610)
  Bump byte-buddy from 1.13.0 to 1.14.0 (apache#11609)
  Bump maven-javadoc-plugin from 3.4.1 to 3.5.0 (apache#11608)
  Bump micrometer-tracing-bom from 1.0.1 to 1.0.2 (apache#11607)
  3.2 consumer proxy invocation handler (apache#11108)
  Update DubboReference.java (apache#11621)
  Bump version to 3.1.8-SNAPSHOT
  Add Consumer Metrics (apache#11542)
  Backport of remove apache-rat-plugin. (apache#11523) (apache#11592)
  Update codecov config (apache#11582)
  ...
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
@mytang0 @lcb11
Rest bugfix & optimization (apache#11617)
5f12d12 
* Modifier optimize

* rawtypes problem optimize

* Remove commented redundant code

* Constants optimize

* Fix consistency bug

* Support exception mapper extension

* resolve conflict
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mytang0 @codecov-commenter @AlbumenJ