Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hasPreparedInternalModule is always false. (#11535) #11536

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix hasPreparedInternalModule is always false. (#11535) #11536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d899b
Fix hasPreparedInternalModule is always false. (#11535)
KamToHung Feb 12, 2023
8725323
Fix hasPreparedInternalModule is always false. (#11535)
KamToHung Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...o-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,7 @@ public void prepareInternalModule() {
// wait for internal module startup
try {
future.get(5, TimeUnit.SECONDS);
hasPreparedInternalModule = true;
} catch (Exception e) {
logger.warn(CONFIG_FAILED_START_MODEL, "", "", "wait for internal module startup failed: " + e.getMessage(), e);
}
Expand Down Expand Up @@ -772,7 +773,7 @@ private DynamicConfiguration prepareEnvironment(ConfigCenterConfig configCenter)
dynamicConfiguration = getDynamicConfiguration(configCenter.toUrl());
} catch (Exception e) {
if (!configCenter.isCheck()) {
logger.warn(CONFIG_FAILED_INIT_CONFIG_CENTER, "", "","The configuration center failed to initialize", e);
logger.warn(CONFIG_FAILED_INIT_CONFIG_CENTER, "", "", "The configuration center failed to initialize", e);
configCenter.setInitialized(false);
return null;
} else {
Expand Down