Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasPreparedInternalModule is always false. (#11535) #11536

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

KamToHung
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@KamToHung
Copy link
Contributor Author

Solution to #11535.

@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11536 (8725323) into 3.2 (cc32ebe) will decrease coverage by 4.80%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                3.2   #11536      +/-   ##
============================================
- Coverage     69.63%   64.83%   -4.80%     
+ Complexity      117       14     -103     
============================================
  Files          1561     1512      -49     
  Lines         83705    62895   -20810     
  Branches      14913     9173    -5740     
============================================
- Hits          58285    40776   -17509     
+ Misses        20530    17876    -2654     
+ Partials       4890     4243     -647     
Impacted Files Coverage Δ
...ubbo/config/deploy/DefaultApplicationDeployer.java 72.97% <50.00%> (-8.99%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) ⬇️
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) ⬇️
... and 494 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 6ded7b2 into apache:3.2 Feb 14, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 14, 2023
* 3.2:
  Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547)
  Bump consul-api from 1.4.2 to 1.4.5 (apache#11545)
  Bump maven-core from 3.8.7 to 3.9.0 (apache#11546)
  Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548)
  Bump byte-buddy from 1.12.22 to 1.13.0 (apache#11550)
  Bump maven-plugin-api from 3.8.7 to 3.9.0 (apache#11551)
  Rename file cache to prevent being duplicated with CacheFilter (apache#11530)
  Fix hasPreparedInternalModule is always false. (apache#11535) (apache#11536)
  collect jacoco result (apache#11532)
  optimize MockDirInvocation setObjectAttachmentIfAbsent method code (apache#11527)
  Metrics Count Optimization (apache#11529)
  Tri grpc compatibility (apache#11544)
  Fix NPE when removing registry (apache#11514)

# Conflicts:
#	dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/DefaultMetricsCollector.java
#	dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/stat/MetricsStatComposite.java
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants