Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix init config problem in HystrixFilter #731

Merged
merged 4 commits into from
Aug 29, 2020

Conversation

YGrylls
Copy link
Contributor

@YGrylls YGrylls commented Aug 28, 2020

What this PR does:
This PR fixes a problem that config related functions try to read consumer config when using HystrixFilter on provider side.
Which issue(s) this PR fixes:

Fixes #710
Fixes #666

Does this PR introduce a user-facing change?:

Some comments are also added in hystrix_filter to help use this filter

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to provide a sample in apache/dubbo-samples?

@YGrylls
Copy link
Contributor Author

YGrylls commented Aug 29, 2020

Would you like to provide a sample in apache/dubbo-samples?

@zouyx OK

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hxmhlt hxmhlt merged commit d862270 into apache:develop Aug 29, 2020
@zouyx zouyx added the improve Refactor or improve label Sep 4, 2020
@zouyx zouyx linked an issue Sep 4, 2020 that may be closed by this pull request
@zouyx zouyx added this to the 1.5.2 milestone Sep 4, 2020
@zouyx zouyx added bug Something isn't working and removed improve Refactor or improve labels Sep 4, 2020
zouyx added a commit to zouyx/dubbo-go that referenced this pull request Sep 22, 2020
Fix: fix init config problem in HystrixFilter
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Fix: fix init config problem in HystrixFilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initHystrixConfigProvider初始化错误
4 participants