Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hystrix filter initHystrixConfigProvider incorrect #666

Closed
seasidesky opened this issue Jul 20, 2020 · 4 comments
Closed

hystrix filter initHystrixConfigProvider incorrect #666

seasidesky opened this issue Jul 20, 2020 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone

Comments

@seasidesky
Copy link

What happened:
https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237

filterConfig := config.GetConsumerConfig().FilterConf.(map[interface{}]interface{})[HYSTRIX]

there is a misuse of config.GetConsumerConfig()

What you expected to happen:
https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237
is expected to like this

filterConfig := config.GetProviderConfig().FilterConf.(map[interface{}]interface{})[HYSTRIX]

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@hxmhlt
Copy link
Contributor

hxmhlt commented Jul 21, 2020

Hi,Hystrix is a fuse solution. As we know, fuses are defined on the consumer side, because fusing is an active protection from the perspective of the client.

@zouyx zouyx added this to the 1.5.2 milestone Aug 27, 2020
@zouyx zouyx added bug Something isn't working duplicate This issue or pull request already exists labels Aug 27, 2020
@zouyx zouyx closed this as completed Aug 27, 2020
@zouyx
Copy link
Member

zouyx commented Aug 27, 2020

the same to #710

@YGrylls
Copy link
Contributor

YGrylls commented Aug 27, 2020

@seasidesky Thank you for mention this. Yes, this is a known bug. Will be fixed this weekend and included in the next release at about mid September. #710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants