Fix: fix AssembleMsg bad use, pass []any as any in variadic function #1964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
i am write a linter to lint bad use
pass []any as any in variadic function
and check the top go repo.the
AssembleMsg
func code is here https://github.com/alibaba/sentinel-golang/blob/2af86608857884da543eabe7941b61d60edc51a4/logging/logging.go#L152-L208if someone call
DubboLoggerWrapper.Info
withInfo("msg", "name", "hello", "address", "world")
for log,it will pass whole []any as any into func
AssembleMsg
,and got
kvs: ["name", "hello", "adress", "world"]
instead of"name":"hello", "address":"world"
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed