Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove consumer of polaris #1962

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

cjphaha
Copy link
Member

@cjphaha cjphaha commented Jul 9, 2022

This pr removes the consumer and watch logic in the Polaris registry.

@codecov-commenter
Copy link

Codecov Report

Merging #1962 (f58923c) into master (f164c81) will decrease coverage by 0.14%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
- Coverage   44.48%   44.34%   -0.15%     
==========================================
  Files         284      283       -1     
  Lines       17038    17023      -15     
==========================================
- Hits         7580     7549      -31     
- Misses       8654     8670      +16     
  Partials      804      804              
Impacted Files Coverage Δ
cluster/cluster/base/cluster_invoker.go 24.44% <ø> (ø)
cluster/cluster/broadcast/cluster_invoker.go 80.00% <ø> (ø)
cluster/cluster/failback/cluster_invoker.go 75.82% <ø> (ø)
cluster/cluster/failover/cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster/failsafe/cluster_invoker.go 81.81% <ø> (ø)
cluster/cluster/forking/cluster_invoker.go 58.33% <ø> (ø)
cluster/loadbalance/p2c/loadbalance.go 76.36% <ø> (ø)
cluster/loadbalance/ringhash/ringhash.go 63.33% <ø> (ø)
cluster/router/tag/match.go 90.69% <ø> (ø)
cluster/router/tag/router.go 59.64% <ø> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abbc2e...f58923c. Read the comment docs.

@cjphaha cjphaha changed the title Ftr: remove consumer of polaris Fix: remove consumer of polaris Jul 9, 2022
@AlexStocks AlexStocks merged commit 7b99da6 into apache:master Jul 9, 2022
AlexStocks added a commit that referenced this pull request Jul 15, 2022
…1964)

* build(deps): bump github.com/emicklei/go-restful/v3 from 3.7.4 to 3.8.0 (#1929)

Bumps [github.com/emicklei/go-restful/v3](https://github.com/emicklei/go-restful) from 3.7.4 to 3.8.0.
- [Release notes](https://github.com/emicklei/go-restful/releases)
- [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md)
- [Commits](emicklei/go-restful@v3.7.4...v3.8.0)

---
updated-dependencies:
- dependency-name: github.com/emicklei/go-restful/v3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bugfix: remove consumer of polaris (#1962)

* Fix: fix pass []any as any in variadic function `AssembleMsg`

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AlexStocks <[email protected]>
Co-authored-by: 氕氘氚 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants