Skip to content

fix: Improve null handling in array_to_string function #18076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Weijun-H merged 2 commits into from
Oct 16, 2025
Merged

fix: Improve null handling in array_to_string function #18076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45038a3
fix: Improve null handling in array_to_string function
Weijun-H Oct 15, 2025
c6bc651
chore
Weijun-H Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 37 additions & 21 deletions datafusion/functions-nested/src/string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,41 +369,57 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
List(..) => {
let list_array = as_list_array(&arr)?;
for i in 0..list_array.len() {
compute_array_to_string(
arg,
list_array.value(i),
delimiter.clone(),
null_string.clone(),
with_null_string,
)?;
if !list_array.is_null(i) {
compute_array_to_string(
arg,
list_array.value(i),
delimiter.clone(),
null_string.clone(),
with_null_string,
)?;
} else if with_null_string {
arg.push_str(&null_string);
arg.push_str(&delimiter);
}
}

Ok(arg)
}
FixedSizeList(..) => {
let list_array = as_fixed_size_list_array(&arr)?;

for i in 0..list_array.len() {
compute_array_to_string(
arg,
list_array.value(i),
delimiter.clone(),
null_string.clone(),
with_null_string,
)?;
if !list_array.is_null(i) {
compute_array_to_string(
arg,
list_array.value(i),
delimiter.clone(),
null_string.clone(),
with_null_string,
)?;
} else if with_null_string {
arg.push_str(&null_string);
arg.push_str(&delimiter);
}
}

Ok(arg)
}
LargeList(..) => {
let list_array = as_large_list_array(&arr)?;
for i in 0..list_array.len() {
compute_array_to_string(
arg,
list_array.value(i),
delimiter.clone(),
null_string.clone(),
with_null_string,
)?;
if !list_array.is_null(i) {
compute_array_to_string(
arg,
list_array.value(i),
delimiter.clone(),
null_string.clone(),
with_null_string,
)?;
} else if with_null_string {
arg.push_str(&null_string);
arg.push_str(&delimiter);
}
}

Ok(arg)
Expand Down
2 changes: 1 addition & 1 deletion datafusion/sqllogictest/test_files/array.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4855,7 +4855,7 @@ h,-,-,-,o nil-2-nil-4-5 1|0|3
query T
select array_to_string(arrow_cast([arrow_cast([NULL, 'a'], 'FixedSizeList(2, Utf8)'), NULL], 'FixedSizeList(2, FixedSizeList(2, Utf8))'), ',', '-');
----
-,a,-,-
-,a,-

# array_to_string with columns #1

Expand Down