test: add regression test for unnesting dictionary encoded columns #14395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongcongtoai
commented
Feb 1, 2025
alamb
reviewed
Feb 1, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @duongcongtoai
cc @crepererum
Comment on lines
3342
to
3345
| let make_array_udf_expr1 = Expr::ScalarFunction(ScalarFunction::new_udf( | ||
| make_array_udf(), | ||
| vec![col("column1")], | ||
| )); |
Contributor
There was a problem hiding this comment.
If we rewrote this test to use the DataFrame API I think it would belong here nicely
For example:
Suggested change
| let make_array_udf_expr1 = Expr::ScalarFunction(ScalarFunction::new_udf( | |
| make_array_udf(), | |
| vec![col("column1")], | |
| )); | |
| let make_array_udf_expr1 =make_array_udf() | |
| .call(vec![col("column1")])); |
Then instead of LogicalPlanBuilder, use the methods on DataFrame 🤔
Contributor
Author
There was a problem hiding this comment.
thanks, i applied the suggestion
alamb
approved these changes
Feb 2, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks again @duongcongtoai
cj-zhukov
pushed a commit
to cj-zhukov/datafusion
that referenced
this pull request
Feb 3, 2025
…pache#14395) * chore: add regression test for unnest dict encoded cols * chore: use dataframe api for testing * chore: rm unused dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
make_array->unnestw/ dict-encoded strings fails #6057 was fixed long ago, this PR is only to add regression testmake_array->unnestw/ dict-encoded strings fails #6057Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?