Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case-sensitive identifier when decorrelating predicate subquery #12443

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Sep 12, 2024

Which issue does this PR close?

Closes #12442 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

yes

Are there any user-facing changes?

@github-actions github-actions bot added optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels Sep 12, 2024
@goldmedal goldmedal marked this pull request as ready for review September 12, 2024 14:19
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 👌 -- very nice @goldmedal

Thank you

.map(|col| {
Column::from_qualified_name(format!("{}.{}", subquery_alias, col.name))
})
.map(|col| Column::new(Some(subquery_alias), &col.name))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit bdb3d35 into apache:main Sep 12, 2024
25 checks passed
@goldmedal goldmedal deleted the bugfix/fix-decorrelate-upper-case branch September 12, 2024 17:09
@goldmedal
Copy link
Contributor Author

Thanks @alamb

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to decorrelate the predicate subquery with the uppercase column name
2 participants