Remove unused AggregateOptions struct and scalar_update_factor config setting
#12241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the AggregateOptions struct in case we need it later. apache#11998
github-actions
bot
added
common
findepi
approved these changes
Aug 29, 2024
|
Looking at the build errors, it might be necessary to fully remove the |
github-actions
bot
added
documentation
findepi
approved these changes
Aug 31, 2024
alamb
changed the title
AggregateOptions struct as well as scalar_update_factor from AggregateOptions
alamb
changed the title
AggregateOptions struct as well as scalar_update_factor from AggregateOptionsAggregateOptions struct and scalar_update_factor config setting
alamb
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11998 .
Rationale for this change
Remove unused config in AggregateOptions. Keep the parent struct open in case we need it later. I am fine to removing the option struct.
What changes are included in this PR?
Are these changes tested?
no new test. just existing cargo test.
Are there any user-facing changes?