Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused config value scalar_update_factor #11998

Closed
alamb opened this issue Aug 14, 2024 · 2 comments · Fixed by #12241
Closed

Remove unused config value scalar_update_factor #11998

alamb opened this issue Aug 14, 2024 · 2 comments · Fixed by #12241
Assignees
@jc4x4 @caicancai
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Aug 14, 2024

Is your feature request related to a problem or challenge?

I noticed while looking at other things I noticed that scalar_update_factor is no longer used

https://github.com/search?q=repo%3Aapache%2Fdatafusion%20scalar_update_factor&type=code

Describe the solution you'd like

Remove the unused config option from the code / comments

Describe alternatives you've considered

We could leave it in -- it isn't really harming anything

Additional context

No response
@alamb alamb added enhancement New feature or request good first issue Good for newcomers labels Aug 14, 2024
@caicancai
Copy link
Member

take

jc4x4 added a commit to jc4x4/datafusion that referenced this issue Aug 29, 2024
@jc4x4
Remove scalar_update_factor from AggregateOptions
e82b4a4 
Keeping the AggregateOptions struct in case we need it later.

apache#11998
@jc4x4
Copy link
Contributor

jc4x4 commented Aug 29, 2024

take

@jc4x4 jc4x4 mentioned this issue Aug 29, 2024
Merged
lewiszlw pushed a commit that referenced this issue Sep 2, 2024
@jc4x4
Remove unused AggregateOptions struct and scalar_update_factor co…
dd32089 
…nfig setting (#12241)

* Remove scalar_update_factor from AggregateOptions

Keeping the AggregateOptions struct in case we need it later.

#11998

* Remove AggregateOption; update configs.md

* Run prettier

* Fix cargo doc
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jc4x4 jc4x4

@caicancai caicancai

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused AggregateOptions struct and scalar_update_factor config setting jc4x4/datafusion
3 participants
@alamb @jc4x4 @caicancai