Improve rpad udf by using a GenericStringBuilder #12070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late update, got some personal issue last week |
|
lgtm |
alamb
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Likewise this looks good to me -- thank you @Lordworms
We just need to sort out the cargo fmt CI Error
maybe we could make two separate macros? Or use StringArrayType to make generic functions instead -- see #12027
|
Sure |
alamb
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Awesome -- very nice @Lordworms
Thank you for the review and help @Omega359
| let length = if length < 0 { 0 } else { length as usize }; | ||
| let graphemes = string.graphemes(true).collect::<Vec<&str>>(); | ||
| let fill_chars = fill.chars().collect::<Vec<char>>(); | ||
| pub fn rpad<StringArrayLen: OffsetSizeTrait, FillArrayLen: OffsetSizeTrait>( |
There was a problem hiding this comment.
😍 -- 100% for no more macros!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11997
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?