Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up rpad implementation to use StringBuilder #11997

Closed
alamb opened this issue Aug 14, 2024 · 1 comment · Fixed by #12070
Closed

Speed up rpad implementation to use StringBuilder #11997

alamb opened this issue Aug 14, 2024 · 1 comment · Fixed by #12070
Assignees
@Lordworms

Comments

@alamb
Copy link
Contributor

alamb commented Aug 14, 2024 •
edited
Loading

Usecase

@Omega359 made a nice improvement to lpad in #11987 to make the code cleaner and faster.

This ticket tracks the work to apply the same treatment of #11987 to rpad -- which @Lordworms ported in #11942

          rpad update with utf8view wasn't committed yet. I know it would work anyways but I think now that rpad update is committed it's good to uncomment.

Originally posted by @Omega359 in #11987 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lordworms Lordworms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve rpad udf by using a GenericStringBuilder Lordworms/arrow-datafusion
2 participants
@alamb @Lordworms