-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add SessionState to MockContextProvider just like SessionContextProvider #11940
Conversation
Cleaning up some backlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Jay Zhan <[email protected]>
Co-authored-by: Jay Zhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really nice to me -- thank you @dharanad and @jayzhan211
.with_udf(string::concat().as_ref().clone()) | ||
.with_udf(make_udf( | ||
let state = MockSessionState::default() | ||
.with_scalar_function(Arc::new(unicode::character_length().as_ref().clone())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Which issue does this PR close?
Closes #11531
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?