Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add SessionState to MockContextProvider just like SessionContextProvider #11531

Closed
dharanad opened this issue Jul 18, 2024 · 1 comment · Fixed by #11940
Closed

chore: Add SessionState to MockContextProvider just like SessionContextProvider #11531

dharanad opened this issue Jul 18, 2024 · 1 comment · Fixed by #11940
Assignees
Labels
enhancement New feature or request

Comments

@dharanad
Copy link
Contributor

Is your feature request related to a problem or challenge?

          I prefer not to re-introduce `with_expr_planner` back for context provider.

It is better to use session state in context, and add planner into session state.

Similar to SessionContextProvider

struct SessionContextProvider<'a> {
    state: &'a SessionState,
    ...
}

Originally posted by @jayzhan211 in #11487 (comment)

This is cleanup task to remove functions like with_udaf with_expr_planner from MockContextProvider and make it consistent with public interfaces. We need to update all the testcases which are affected by this change.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@dharanad
Copy link
Contributor Author

take

@alamb alamb changed the title chroe: Add SessionState to MockContextProvider just like SessionContextProvider chore: Add SessionState to MockContextProvider just like SessionContextProvider Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant