Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose public method for optimizing physical plans #11879

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #11873

Rationale for this change

See #11873

What changes are included in this PR?

  • Make physical optimizer method public and rename it
  • Add an example

Are these changes tested?

Existing tests

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Aug 7, 2024
@andygrove andygrove requested review from alamb and viirya August 7, 2024 16:17
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @andygrove

@@ -123,5 +124,19 @@ async fn to_physical_plan_step_by_step_demo(
.plan
);

// Call the physical optimizer with an existing physical plan (in this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
FYI @waynexia -- the example you added in #11716 is already being extended and used 🎉

@viirya
Copy link
Member

viirya commented Aug 7, 2024

Thanks @andygrove @alamb

@andygrove andygrove merged commit cd322f1 into apache:main Aug 7, 2024
24 checks passed
@andygrove andygrove deleted the public-physical-optimizer branch August 7, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose physical optimizer API
3 participants