Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose some fields on session state #11716

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

waynexia
Copy link
Member

Which issue does this PR close?

Closes #11715

Rationale for this change

As stated in #11715, this patch implements the second approach for discussion.

What changes are included in this PR?

Three new APIs in SessionState for planning and optimizing.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Jul 30, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @waynexia

It might be worth creating some sort of example to show how these APIs are used but we could certainly do it as a follow on PR

@waynexia
Copy link
Member Author

Sounds good 👍 I'll add one in this patch.

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia
Copy link
Member Author

I add a new one planner_api.rs as the example. I didn't find an appropriate one from existing examples, please let me know if there is.

Signed-off-by: Ruihang Xia <[email protected]>
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @waynexia

/// 1. Analyzing and optimizing logical plan
/// 2. Converting logical plan into physical plan
///
/// The code in this example shows two ways to convert a logical plan into
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@alamb alamb merged commit 6508fa2 into apache:main Jul 31, 2024
24 checks passed
@waynexia waynexia deleted the expose-session-state branch July 31, 2024 12:21
@waynexia waynexia restored the expose-session-state branch August 2, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow fine-tune planner steps
2 participants