-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose some fields on session state #11716
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me -- thank you @waynexia
It might be worth creating some sort of example to show how these APIs are used but we could certainly do it as a follow on PR
Sounds good 👍 I'll add one in this patch. |
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
I add a new one |
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me -- thank you @waynexia
/// 1. Analyzing and optimizing logical plan | ||
/// 2. Converting logical plan into physical plan | ||
/// | ||
/// The code in this example shows two ways to convert a logical plan into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Which issue does this PR close?
Closes #11715
Rationale for this change
As stated in #11715, this patch implements the second approach for discussion.
What changes are included in this PR?
Three new APIs in
SessionState
for planning and optimizing.Are these changes tested?
Are there any user-facing changes?