move aggregate_statistics, enforce_sorting, limited_distinct_aggregtion and replace_with_order_preserving_variants to datafusion-physical-optimizer crate
#11793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion and replace_with_order_preserving_variants to datafusion-physical-optimizer crate
Weijun-H
force-pushed
the
move-to-datafusion-physical-optimizer-crate
branch
from
70a2c1b
to
5b5c8d8
Compare
|
it would be better to split this pr into small pieces since it is too large |
|
Thank you @Weijun-H |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts #11502
Rationale for this change
What changes are included in this PR?
move the following functions to
datafusion-physical-optimizercrateaggregate_statisticsenforce_sortingsort_pushdownlimited_distinct_aggregtionreplace_with_order_preserving_variantsAdditionally, leave the tests in the core module because they have too many dependencies with the core. They were all renamed with '_test'.
Are these changes tested?
Are there any user-facing changes?