Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename functions-array to functions-nested #11602

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Rename functions-array to functions-nested #11602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cb817d4
rename create to function-nested
goldmedal Jul 22, 2024
fd0d5fb
rename array_expressions to nested_expression
goldmedal Jul 22, 2024
f309e86
rename doc and workflow
goldmedal Jul 22, 2024
727b25b
cargo fmt
goldmedal Jul 22, 2024
4fde39e
update lock
goldmedal Jul 22, 2024
c7f97de
Update readme
goldmedal Jul 22, 2024
e5ca91f
rename the missing parts
goldmedal Jul 22, 2024
55b0023
rename the planner
goldmedal Jul 22, 2024
93bbcee
add backward compatibility
goldmedal Jul 23, 2024
a05fe1f
Merge branch 'main' into chore/11598-rename-array-to-nested
goldmedal Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion datafusion/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ name = "datafusion"
path = "src/lib.rs"

[features]
# Used to enable the avro format
nested_expressions = ["datafusion-functions-nested"]
# This feature is deprecated. Use the `nested_expressions` feature instead.
array_expressions = ["nested_expressions"]
Comment on lines +44 to +45
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no better way to annotate a feature that is deprecated. Just leave a comment for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok -- thank you

# Used to enable the avro format
avro = ["apache-avro", "num-traits", "datafusion-common/avro"]
backtrace = ["datafusion-common/backtrace"]
compression = ["xz2", "bzip2", "flate2", "zstd", "async-compression", "tokio-util"]
Expand Down
7 changes: 7 additions & 0 deletions datafusion/core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,13 @@ pub mod functions_nested {
pub use datafusion_functions_nested::*;
}

/// re-export of [`datafusion_functions_nested`] crate as [`functions_array`] for backward compatibility, if "nested_expressions" feature is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

#[deprecated(since = "41.0.0", note = "use datafusion-functions-nested instead")]
pub mod functions_array {
#[cfg(feature = "nested_expressions")]
pub use datafusion_functions_nested::*;
}

/// re-export of [`datafusion_functions_aggregate`] crate
pub mod functions_aggregate {
pub use datafusion_functions_aggregate::*;
Expand Down