Rename functions-array to functions-nested
#11602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
alamb
reviewed
Jul 22, 2024
| pub mod functions_array { | ||
| #[cfg(feature = "array_expressions")] | ||
| pub use datafusion_functions_array::*; | ||
| /// re-export of [`datafusion_functions_nested`] crate, if "nested_expressions" feature is enabled |
There was a problem hiding this comment.
Maybe we can leave a pub use functions_array here to help migration
Something like
#[deprecated(since = "41.0.0", note = "use datafusion-functions-nested instead")]
pub mod functions_array {
#[cfg(feature = "nested_expressions")]
pub use datafusion_functions_nested::*;
}We could do something similar with the feature flags, but maybe that is too complicated to be worth it
There was a problem hiding this comment.
Good idea. Thanks. I'll try to do it for the crate and feature.
alamb
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Thanks @goldmedal -- I think this is an improvement, though I left a suggestion to help people upgrade
goldmedal
commented
Jul 23, 2024
Comment on lines
+44
to
+45
| # This feature is deprecated. Use the `nested_expressions` feature instead. | ||
| array_expressions = ["nested_expressions"] |
There was a problem hiding this comment.
I have no better way to annotate a feature that is deprecated. Just leave a comment for it.
There was a problem hiding this comment.
I think this is ok -- thank you
jayzhan211
reviewed
Jul 24, 2024
dev/release/crate-deps.svg
Outdated
There was a problem hiding this comment.
Cool! I didn't know we have crate-deps graph
alamb
approved these changes
Jul 24, 2024
| pub use datafusion_functions_nested::*; | ||
| } | ||
|
|
||
| /// re-export of [`datafusion_functions_nested`] crate as [`functions_array`] for backward compatibility, if "nested_expressions" feature is enabled |
|
Thanks @alamb and @jayzhan211 ! |
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
Aug 10, 2024
The package was renamed upstream. Ref: apache/datafusion#11602
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
Aug 20, 2024
The package was renamed upstream. Ref: apache/datafusion#11602
andygrove
pushed a commit
to apache/datafusion-python
that referenced
this pull request
Aug 23, 2024
* update datafusion deps to point to githuc.com/apache/datafusion Datafusion 41 is not yet released on crates.io. * update TableProvider::scan Ref: apache/datafusion#11516 * use SessionStateBuilder The old constructor is deprecated. Ref: apache/datafusion#11403 * update AggregateFunction Upstream Changes: - The field name was switched from `func_name` to func. - AggregateFunctionDefinition was removed Ref: apache/datafusion#11803 * update imports in catalog Catlog API was extracted to a separate crate. Ref: apache/datafusion#11516 * use appropriate path for approx_distinct Ref: apache/datafusion#11644 * migrate AggregateExt to ExprFunctionExt Also removed `sqlparser` dependency since it's re-exported upstream. Ref: apache/datafusion#11550 * update regr_count tests for new return type Ref: apache/datafusion#11731 * migrate from function-array to functions-nested The package was renamed upstream. Ref: apache/datafusion#11602 * cargo fmt * lock datafusion deps to 41 * remove todo from cargo.toml All the datafusion dependencies are re-exported, but I still need to figure out *why*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11598 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?