-
Notifications
You must be signed in to change notification settings - Fork 267
fix: [iceberg] Fall back to spark for schemas with empty structs #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hsiang-c fyi |
|
@andygrove We might need to add |
Done. This won't fully test the fix because shuffle is still disabled in Iceberg. I will create a separate follow-on PR to update the diff and see if there are any other failures related to shuffle after this fix. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
============================================
+ Coverage 56.12% 58.54% +2.41%
- Complexity 976 1283 +307
============================================
Files 119 143 +24
Lines 11743 13216 +1473
Branches 2251 2363 +112
============================================
+ Hits 6591 7737 +1146
- Misses 4012 4250 +238
- Partials 1140 1229 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
TPC-DS failure due to #2206 |
parthchandra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @andygrove
Which issue does this PR close?
Closes #2086
Rationale for this change
What changes are included in this PR?
Fall back to Spark for schemas containing empty structs (seems like an artificial edge case)
How are these changes tested?
I tested this fix manually with Iceberg