-
Notifications
You must be signed in to change notification settings - Fork 267
test: Run Iceberg Spark tests only when PR title contains [iceberg] #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| iceberg-spark-sql: | ||
| if: contains(github.event.pull_request.title, '[iceberg]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more reference on conditional job execution: https://docs.github.com/en/actions/how-tos/writing-workflows/choosing-when-your-workflow-runs/using-conditions-to-control-job-execution#overview
kazuyukitanimura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending with Ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1976 +/- ##
============================================
+ Coverage 56.12% 58.11% +1.98%
- Complexity 976 1147 +171
============================================
Files 119 132 +13
Lines 11743 13022 +1279
Branches 2251 2417 +166
============================================
+ Hits 6591 7568 +977
- Misses 4012 4225 +213
- Partials 1140 1229 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hsiang-c
Which issue does this PR close?
Closes #. #1964
Rationale for this change
Make Iceberg Spark CI optional until we can speed it up.
What changes are included in this PR?
Only run the Iceberg Spark workflow when PR title has
[iceberg].How are these changes tested?