Skip to content

Conversation

@hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Jul 1, 2025

Which issue does this PR close?

Closes #. #1964

Rationale for this change

Make Iceberg Spark CI optional until we can speed it up.

What changes are included in this PR?

Only run the Iceberg Spark workflow when PR title has [iceberg].

How are these changes tested?


jobs:
iceberg-spark-sql:
if: contains(github.event.pull_request.title, '[iceberg]')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending with Ci

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.11%. Comparing base (f09f8af) to head (c56f538).
Report is 310 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1976      +/-   ##
============================================
+ Coverage     56.12%   58.11%   +1.98%     
- Complexity      976     1147     +171     
============================================
  Files           119      132      +13     
  Lines         11743    13022    +1279     
  Branches       2251     2417     +166     
============================================
+ Hits           6591     7568     +977     
- Misses         4012     4225     +213     
- Partials       1140     1229      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kazuyukitanimura kazuyukitanimura changed the title Run Iceberg Spark tests only when PR title contains [iceberg] test: Run Iceberg Spark tests only when PR title contains [iceberg] Jul 2, 2025
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hsiang-c

@andygrove andygrove merged commit 9817ceb into apache:main Jul 2, 2025
95 of 98 checks passed
@hsiang-c hsiang-c deleted the optional_iceberg_spark_test branch July 2, 2025 16:34
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants