-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace superspawn & child_process with execa #862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes expected to remain here or should be moved to the Dropping Q PR
? These changes kinda blend together and could be done in either PR I am guessing.
Co-authored-by: Raphael von der Grün <[email protected]>
Co-authored-by: Raphael von der Grün <[email protected]>
Plus: Remove useless trimming of execa output Co-authored-by: Raphael von der Grün <[email protected]>
Co-authored-by: Raphael von der Grün <[email protected]>
Co-authored-by: Raphael von der Grün <[email protected]>
Co-authored-by: Raphael von der Grün <[email protected]>
As #860 has been merged, I went ahead and rebased the branch with latest master. |
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
=========================================
- Coverage 66.46% 66.37% -0.1%
=========================================
Files 19 19
Lines 1855 1847 -8
=========================================
- Hits 1233 1226 -7
+ Misses 622 621 -1
Continue to review full report at Codecov.
|
Motivation and Context
apache/cordova#16
Includes commit from #860 (will rebase ASAP). Depends on #832 and #861.
Description
Replace
superspawn
&child_process
usage withexeca
.Testing
npm t
Checklist