Don't filter gradle's stderr anymore

[raphinesse]

Motivation and Context

When building the project by running gradlew, we filter its output on stderr to omit a specific diagnostic message. This complicated refactorings in the past and also affects upcoming refactorings regarding Q and superspawn.

The reason this code exists is a weak one IMHO. The Visual Studio integration deemed the build to have failed if anything has been output on stderr. Thus the aforementioned diagnostic message on stderr caused successful builds to count as failed ones.

IMHO, the current behavior should be removed for various reasons:

• Diagnostics on stderr are not uncommon, so the success of the command should be determined from the returned Promise or the process' exit code respectively
• Unclear if code works correctly & reliably: the code is written as if only complete lines were passed into progress. But superspawn calls notify for every chunk it receives in a data event on stderr. AFAIK it is not guaranteed that these chunks will be individual and complete lines.
• Unclear if code is up-to-date
• Code is untested
• Complicates refactorings

Description

This PR removes all output filtering in ProjectBuilder.prototype.build.

Testing

Automated tests still pass.

[codecov-io]

Codecov Report

Merging #860 into master will increase coverage by 0.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   66.25%   66.46%   +0.21%     
==========================================
  Files          19       19              
  Lines        1861     1855       -6     
==========================================
  Hits         1233     1233              
+ Misses        628      622       -6

Impacted Files	Coverage Δ
...n/templates/cordova/lib/builders/ProjectBuilder.js	67.79% <100%> (+2.22%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcaab36...e66f664. Read the comment docs.

[timbru31]

LGTM - it would be great if this could be tested though. Still +1, given the fact that Microsoft seems to decide to ditch .jsproj (and maybe more) with the recent Visual Studio update.