chore: drop q module #833
chore: drop q module #833
Conversation
|
CI failures are due to Node.js 6 and 8 which are removed in PR #832 |
|
Rebased against master |
There was a problem hiding this comment.
Approved, but should be merged after #862 since this PR omits removal of some Q usage that is done there.
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
- Coverage 66.46% 66.32% -0.15%
==========================================
Files 19 19
Lines 1855 1850 -5
==========================================
- Hits 1233 1227 -6
- Misses 622 623 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I don't know what you did, but all the changes that were made to this PR by erisu#1 are reverted now. Please re-apply them.
* Fix faulty transformation of Q.when * Simplify thenResolve transformation Removes unnecesary Promise wrapping in onFulfilled callback. * Transform .done calls to .then or .catch The important thing is that we always handle rejections. * Remove Q from specs Requires Jasmine 3.5 * Replace Q.timeout w/ Promise.race & custom function
|
Thank you for the review and helping with the rebase @raphinesse |
Motivation and Context
qmodule for native promisesDescription
qusagesTesting
npm tNotice: Node 6 and 8 tests in Travis CI and AppVeyor fails. This PR is intended for next major as it uses APIs from Node
>=10. PR #832 will be required first.Checklist