Implement resourceiconresponse as interface{} #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
|
cc @davidjumani @shwstppr can you assist? |
Contributor
Author
|
Btw I know this is out of scope as ACS 4.17 support is still drafted here #38, but some repos downstream depend on this change (in my case https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack) |
shwstppr
approved these changes
Mar 30, 2023
davidjumani
approved these changes
Mar 31, 2023
Contributor
|
Merging based on approvals |
|
🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All "icon" fields are set to be of resourceiconresponse type, however that type is not defined anywhere, making the icon field resolving to a string.
This isn't correct as ACS returns the Icon as an object, which in term causes these types of error:
json: cannot unmarshal object into Go struct field VirtualMachinesMetric.virtualmachine.icon of type stringThis change sets the type of resourceiconresponse type to be an empty interface{}, to guarantee some backward compatibility and ensure that the unmarshalling works as intended.
Tested againt ACS 4.17.1