-
Notifications
You must be signed in to change notification settings - Fork 36
Add ACS 4.17 support #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Pearl1594 You may wanna test / update the testdata to ensure that it hasn't changed in 4.17 |
|
Yes, was going to spend some time on that, hence was marked as a draft PR. |
|
Hello, I've created a PR which fixes Icon type behavior in 4.17: #45. Please notify me if you want to merge it as part of this PR. |
|
cc @shwstppr may need rework or latest api json for use to generate the bindings against 4.17.2 |
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
|
With the release of 4.18, do we want to just move forward with updating for that instead @rohityadavcloud ? |
|
@mlsorensen cc @rohityadavcloud is it okay if merge this and add a release for 4.17 support and then work for 4.18 release? |
|
@shwstppr I'm ok to move forward with adding the 4.17 support if this PR is ready. My concern was only that this has been hanging out so long I wondered if we should just move on if it still needs work. |
|
Lgtm |
No description provided.