Skip to content

Conversation

@Pearl1594
Copy link
Contributor

No description provided.

@davidjumani
Copy link
Contributor

@Pearl1594 You may wanna test / update the testdata to ensure that it hasn't changed in 4.17

@Pearl1594
Copy link
Contributor Author

Yes, was going to spend some time on that, hence was marked as a draft PR.

@vdombrovski
Copy link
Contributor

vdombrovski commented Jan 24, 2023

Hello, I've created a PR which fixes Icon type behavior in 4.17: #45. Please notify me if you want to merge it as part of this PR.

@rohityadavcloud rohityadavcloud requested a review from shwstppr March 4, 2023 15:42
@rohityadavcloud
Copy link
Member

cc @shwstppr may need rework or latest api json for use to generate the bindings against 4.17.2

@mlsorensen
Copy link
Contributor

With the release of 4.18, do we want to just move forward with updating for that instead @rohityadavcloud ?

@mlsorensen mlsorensen mentioned this pull request Mar 27, 2023
@shwstppr shwstppr marked this pull request as ready for review March 30, 2023 08:44
@shwstppr
Copy link
Contributor

shwstppr commented Mar 30, 2023

@mlsorensen cc @rohityadavcloud is it okay if merge this and add a release for 4.17 support and then work for 4.18 release?

@mlsorensen
Copy link
Contributor

mlsorensen commented Mar 30, 2023

@shwstppr I'm ok to move forward with adding the 4.17 support if this PR is ready. My concern was only that this has been hanging out so long I wondered if we should just move on if it still needs work.

@rohityadavcloud
Copy link
Member

Lgtm

@rohityadavcloud rohityadavcloud merged commit f4cfaae into apache:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants