-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor per worker histogram metrics #34244
Refactor per worker histogram metrics #34244
Conversation
R: @scwhittle This is a follow up to #33503 |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
3f77ad4
to
8cc2eb9
Compare
...ker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingStepMetricsContainer.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/DelegatingHistogram.java
Outdated
Show resolved
Hide resolved
...le-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java
Show resolved
Hide resolved
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaSinkMetrics.java
Show resolved
Hide resolved
perWorkerHistograms.computeIfAbsent( | ||
KV.of(metricName, bucketType), kv -> new TestHistogramCell(kv)); | ||
return perWorkerHistograms.get(KV.of(metricName, bucketType)); | ||
histograms.computeIfAbsent(KV.of(metricName, bucketType), kv -> new TestHistogramCell(kv)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify the per-worker field is set? To catch error of adding to builder after built
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that, add it in the KafkaSinkMetricsTest.java file instead.
6bdb991
to
4b1ed80
Compare
4b1ed80
to
a6a1dc6
Compare
Run Java_Amazon-Web-Services2_IO_Direct PreCommit |
Run Java PreCommit |
Run Java_Examples_Dataflow PreCommit |
Run Java PreCommit |
Run Java_GCP_IO_Direct PreCommit |
1 similar comment
Run Java_GCP_IO_Direct PreCommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Run Java_GCP_IO_Direct PreCommit |
a6a1dc6
to
88c6d0e
Compare
Run Java_IOs_Direct PreCommit |
Run Java PreCommit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34244 +/- ##
============================================
- Coverage 56.32% 56.31% -0.01%
+ Complexity 3286 3285 -1
============================================
Files 1172 1172
Lines 178933 178943 +10
Branches 3398 3398
============================================
+ Hits 100778 100780 +2
- Misses 74898 74903 +5
- Partials 3257 3260 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Change how histogram metrics are handled as a part of addressing #34195.
Updating how counters are handled will be done in a subsequent PR to limit scope of each change.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.