Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor per worker histogram metrics #34244

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Mar 11, 2025

Change how histogram metrics are handled as a part of addressing #34195.

Updating how counters are handled will be done in a subsequent PR to limit scope of each change.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen
Copy link
Contributor Author

Naireen commented Mar 11, 2025

R: @scwhittle

This is a follow up to #33503

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Naireen Naireen force-pushed the refactor_bq_per_worker_metrics branch from 3f77ad4 to 8cc2eb9 Compare March 11, 2025 06:17
@Naireen Naireen changed the title Refactor bq per worker metrics Refactor per worker histogram metrics Mar 11, 2025
perWorkerHistograms.computeIfAbsent(
KV.of(metricName, bucketType), kv -> new TestHistogramCell(kv));
return perWorkerHistograms.get(KV.of(metricName, bucketType));
histograms.computeIfAbsent(KV.of(metricName, bucketType), kv -> new TestHistogramCell(kv));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify the per-worker field is set? To catch error of adding to builder after built

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, add it in the KafkaSinkMetricsTest.java file instead.

@Naireen Naireen force-pushed the refactor_bq_per_worker_metrics branch 2 times, most recently from 6bdb991 to 4b1ed80 Compare March 11, 2025 19:35
@Naireen Naireen force-pushed the refactor_bq_per_worker_metrics branch from 4b1ed80 to a6a1dc6 Compare March 11, 2025 19:43
@Naireen Naireen requested a review from scwhittle March 11, 2025 19:45
@Naireen
Copy link
Contributor Author

Naireen commented Mar 11, 2025

Run Java_Amazon-Web-Services2_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 11, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 11, 2025

Run Java_Examples_Dataflow PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 11, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 11, 2025

Run Java_GCP_IO_Direct PreCommit

1 similar comment
@Naireen
Copy link
Contributor Author

Naireen commented Mar 13, 2025

Run Java_GCP_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 13, 2025

Run Java PreCommit

1 similar comment
@Naireen
Copy link
Contributor Author

Naireen commented Mar 13, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 13, 2025

Run Java_GCP_IO_Direct PreCommit

@Naireen Naireen force-pushed the refactor_bq_per_worker_metrics branch from a6a1dc6 to 88c6d0e Compare March 13, 2025 05:42
@Naireen
Copy link
Contributor Author

Naireen commented Mar 13, 2025

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 13, 2025

Run Java PreCommit

@Naireen Naireen mentioned this pull request Mar 13, 2025
3 tasks
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.31%. Comparing base (5d38b8e) to head (88c6d0e).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34244      +/-   ##
============================================
- Coverage     56.32%   56.31%   -0.01%     
+ Complexity     3286     3285       -1     
============================================
  Files          1172     1172              
  Lines        178933   178943      +10     
  Branches       3398     3398              
============================================
+ Hits         100778   100780       +2     
- Misses        74898    74903       +5     
- Partials       3257     3260       +3     
Flag Coverage Δ
java 70.51% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scwhittle scwhittle merged commit 89c6402 into apache:master Mar 13, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants