Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace StorageV1 client with GCS client" #27388

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jul 7, 2023

Reverts #25965 because it broke the Python PostCommits (https://ci-beam.apache.org/job/beam_PostCommit_Python311/358/ is the first failing run). This is the first successful PostCommit run for any python version since that PR was merged

@damccorm
Copy link
Contributor Author

damccorm commented Jul 7, 2023

Run Python 3.10 PostCommit

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #27388 (f35d836) into master (f19c384) will increase coverage by 0.26%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #27388      +/-   ##
==========================================
+ Coverage   71.05%   71.32%   +0.26%     
==========================================
  Files         858      862       +4     
  Lines      104105   105202    +1097     
==========================================
+ Hits        73975    75032    +1057     
- Misses      28581    28621      +40     
  Partials     1549     1549              
Flag Coverage Δ
python 80.52% <75.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/apache_beam/examples/complete/game/user_score.py 62.79% <ø> (ø)
sdks/python/apache_beam/internal/gcp/auth.py 79.16% <ø> (+0.78%) ⬆️
...cp/internal/clients/storage/storage_v1_messages.py 100.00% <ø> (ø)
sdks/python/setup.py 0.00% <ø> (ø)
..._beam/runners/portability/sdk_container_builder.py 37.93% <8.33%> (+1.03%) ⬆️
...apache_beam/runners/dataflow/internal/apiclient.py 77.02% <18.18%> (-0.15%) ⬇️
.../gcp/internal/clients/storage/storage_v1_client.py 65.26% <65.26%> (ø)
sdks/python/apache_beam/io/gcp/gcsio_overrides.py 70.00% <70.00%> (ø)
...e_beam/io/gcp/internal/clients/storage/__init__.py 77.77% <77.77%> (ø)
sdks/python/apache_beam/io/gcp/gcsio.py 92.28% <89.87%> (+25.61%) ⬆️
... and 2 more

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

damccorm commented Jul 7, 2023

Run Python_Runners PreCommit

@damccorm damccorm marked this pull request as ready for review July 7, 2023 13:48
@damccorm
Copy link
Contributor Author

damccorm commented Jul 7, 2023

R: @BjornPrime @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Per discussion, #27390 should fix the specific issue in the description; but there is still internal test breakage. I am fine with revert for now and then do investigation

@damccorm damccorm merged commit 7ce2d00 into master Jul 7, 2023
@damccorm damccorm deleted the revert-25965-replace-storage-client branch July 7, 2023 16:34
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 10, 2023
BjornPrime added a commit to BjornPrime/my-beam that referenced this pull request Jul 13, 2023
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 17, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants