-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Replace StorageV1 client with GCS client" #27388
Conversation
This reverts commit 34a1796.
Run Python 3.10 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #27388 +/- ##
==========================================
+ Coverage 71.05% 71.32% +0.26%
==========================================
Files 858 862 +4
Lines 104105 105202 +1097
==========================================
+ Hits 73975 75032 +1057
- Misses 28581 28621 +40
Partials 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python_Runners PreCommit |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Per discussion, #27390 should fix the specific issue in the description; but there is still internal test breakage. I am fine with revert for now and then do investigation
…che#27388) This reverts commit 34a1796.
…" (apache#27388)" This reverts commit 7ce2d00.
…che#27388) This reverts commit 34a1796.
…che#27388) This reverts commit 34a1796.
Reverts #25965 because it broke the Python PostCommits (https://ci-beam.apache.org/job/beam_PostCommit_Python311/358/ is the first failing run). This is the first successful PostCommit run for any python version since that PR was merged