-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace StorageV1 client with GCS client #25965
Conversation
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer |
Run Python PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much simpler to read, I love it
Run Python 3.11 PostCommit |
Run Python 3.10 PostCommit |
5 similar comments
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
3 similar comments
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
2 similar comments
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
Run Python 3.10 PostCommit |
0b92fe9
to
f0233a2
Compare
Run Python 3.11 PostCommit |
5 similar comments
Run Python 3.11 PostCommit |
Run Python 3.11 PostCommit |
Run Python 3.11 PostCommit |
Run Python 3.11 PostCommit |
Run Python 3.11 PostCommit |
d7f5b7c
to
31e3cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! WIll merge once test passed
…che#27388) This reverts commit 34a1796.
…" (apache#27388)" This reverts commit 7ce2d00.
…che#27388) This reverts commit 34a1796.
…che#27388) This reverts commit 34a1796.
Addresses #25676.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.