Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload HbaseIO with KV<RowKey, RowMutations> #25864

Merged
merged 14 commits into from
Mar 28, 2023

Conversation

georgecma
Copy link
Contributor

@georgecma georgecma commented Mar 16, 2023

Add HbaseIO support for writing RowMutations (ordered by rowkey) to Hbase.
Fixes #25830


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@georgecma georgecma changed the title feat: two-way replication for Hbase-Bigtable replication Overload HbaseIO with KV<RowKey, RowMutations> Mar 16, 2023
@georgecma georgecma marked this pull request as ready for review March 16, 2023 17:29
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the implementation looks good. Left comments about the added coder, and a couple of minor comments. In general, only IO connector classes need to be exposed as public. As for SDK, public class are meant to be used elsewhere and need to consider compatibility on changes.

@Abacn
Copy link
Contributor

Abacn commented Mar 21, 2023

There are following warnings:

Bad practice Warnings
Code	Warning
FS	Format string should use %n rather than \n in org.apache.beam.sdk.io.hbase.HBaseSharedConnection.getDebugString()
Se	Class org.apache.beam.sdk.io.hbase.HBaseIO$WriteRowMutations defines non-transient non-serializable instance field configuration

this can be found by running ./gradlew :sdks:java:io:hbase:spotbugMain locally

@Abacn
Copy link
Contributor

Abacn commented Mar 21, 2023

(Java_xxx_IO_Direct tests should report spotbug as Java_PreCommit. Add to my backlog for fix)

@georgecma
Copy link
Contributor Author

Resolved issues

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just have a couple of comments mostly the new coder implementation.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Abacn Abacn merged commit c0f0f2d into apache:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Overload HbaseIO with KV<RowKey, RowMutations>
2 participants