-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overload HbaseIO with KV<RowKey, RowMutations> #25831
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
test not run due to spotbug: HbaseRowMutationIOTest.java:56 "You should name sfl4j Loggers as LOG." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looked at HBaseIO but not yet tests and utility classes.
By saying "in-order write", what is the requirement? Is that something like <Key=1, RowMutations1> will be written prior to <Key=2, RowMutations1> ? Or just Mutations in a RowMutations
("Performs multiple mutations atomically on a single row.") should be executed in order?
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
Show resolved
Hide resolved
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
Show resolved
Hide resolved
@georgecma Thanks for contribution! I see that this PR is created from your local |
…HBaseIO.java Co-authored-by: Yi Hu <[email protected]>
…HBaseIO.java Co-authored-by: Yi Hu <[email protected]>
…HBaseIO.java Co-authored-by: Yi Hu <[email protected]>
Add HbaseIO support for writing RowMutations (ordered by rowkey) to Hbase.
Fixes #25830
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.