Skip to content

AVRO-3697: [ruby] Test against Ruby 3.2 #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjwp merged 1 commit into from
Dec 31, 2022
Merged

AVRO-3697: [ruby] Test against Ruby 3.2 #2041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/test-lang-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
- '2.7'
- '3.0'
- '3.1'
- '3.2'
steps:
- uses: actions/checkout@v3

Expand All @@ -51,7 +52,7 @@ jobs:
ruby-version: ${{ matrix.ruby }}

- name: Install Dependencies
run: sudo apt-get install -qqy bundler libsnappy-dev
run: sudo apt-get install -qqy libsnappy-dev

- uses: actions/cache@v3
with:
Expand Down Expand Up @@ -83,6 +84,7 @@ jobs:
- '2.7'
- '3.0'
- '3.1'
- '3.2'
steps:
- uses: actions/checkout@v3

Expand All @@ -91,7 +93,7 @@ jobs:
ruby-version: ${{ matrix.ruby }}

- name: Install Dependencies
run: sudo apt-get install -qqy bundler libsnappy-dev
Copy link
Contributor Author

@tjwp tjwp Dec 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundler is already installed by the ruby/setup-ruby action.

run: sudo apt-get install -qqy libsnappy-dev

- uses: actions/cache@v3
with:
Expand Down
5 changes: 0 additions & 5 deletions lang/ruby/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ cd "$(dirname "$0")"
export GEM_HOME="$PWD/.gem/"
export PATH="/usr/local/rbenv/shims:$GEM_HOME/bin:$PATH"

# bootstrap bundler
gem install --no-document -v 1.17.3 bundler
Copy link
Contributor Author

@tjwp tjwp Dec 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of bundler is old (12/27/2018) and no longer needed.


# rbenv is used by the Dockerfile but not the Github action in CI
rbenv rehash 2>/dev/null || echo "Not using rbenv"
Copy link
Contributor Author

@tjwp tjwp Dec 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of rbenv was previously removed from the Dockerfile setup: cf7bfe7#diff-9ad53a2cdd23436f405be61d20306403700f362287b3d86609319919176a6fb6L191-L203

bundle install

for target in "$@"
Expand Down