AVRO-3697: [ruby] Test against Ruby 3.2 #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwp
commented
Dec 30, 2022
| gem install --no-document -v 1.17.3 bundler | ||
|
|
||
| # rbenv is used by the Dockerfile but not the Github action in CI | ||
| rbenv rehash 2>/dev/null || echo "Not using rbenv" |
Contributor
Author
There was a problem hiding this comment.
Use of rbenv was previously removed from the Dockerfile setup: cf7bfe7#diff-9ad53a2cdd23436f405be61d20306403700f362287b3d86609319919176a6fb6L191-L203
tjwp
commented
Dec 30, 2022
| export PATH="/usr/local/rbenv/shims:$GEM_HOME/bin:$PATH" | ||
|
|
||
| # bootstrap bundler | ||
| gem install --no-document -v 1.17.3 bundler |
Contributor
Author
There was a problem hiding this comment.
This version of bundler is old (12/27/2018) and no longer needed.
tjwp
commented
Dec 30, 2022
| ruby-version: ${{ matrix.ruby }} | ||
|
|
||
| - name: Install Dependencies | ||
| run: sudo apt-get install -qqy bundler libsnappy-dev |
Contributor
Author
There was a problem hiding this comment.
bundler is already installed by the ruby/setup-ruby action.
tjwp
added a commit
to tjwp/avro
that referenced
this pull request
Dec 31, 2022
tjwp
added a commit
that referenced
this pull request
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
setup-actionso skipping also installing it as a package saves some time in CIVerifying this change
This change is already covered by the existing Ruby test suite.
Documentation