Skip to content

Fix minor warnings from rust 1.66.0 #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-g merged 3 commits into from
Dec 16, 2022
Merged

Fix minor warnings from rust 1.66.0 #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0088b8
Fix lint error in IT test
martin-g Dec 16, 2022
410c031
Fix lint warning in rustdoc
martin-g Dec 16, 2022
e0938ff
Remove a non-existing label that dependabot tries to set when creatin…
martin-g Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ updates:
interval: "daily"
open-pull-requests-limit: 20
target-branch: master
labels: [auto-dependencies]

- package-ecosystem: "github-actions"
directory: "/"
Expand Down
2 changes: 1 addition & 1 deletion lang/rust/avro/src/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ impl<T> SpecificSingleObjectWriter<T>
where
T: AvroSchema + Into<Value>,
{
/// Write the Into<Value> to the provided Write object. Returns a result with the number
/// Write the `Into<Value>` to the provided Write object. Returns a result with the number
/// of bytes written including the header
pub fn write_value<W: Write>(&mut self, data: T, writer: &mut W) -> AvroResult<usize> {
let v: Value = data.into();
Expand Down
2 changes: 1 addition & 1 deletion lang/rust/avro/tests/io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ fn test_binary_int_encoding() {
#[test]
fn test_binary_long_encoding() {
for (number, hex_encoding) in BINARY_ENCODINGS.iter() {
let encoded = to_avro_datum(&Schema::Long, Value::Long(*number as i64)).unwrap();
let encoded = to_avro_datum(&Schema::Long, Value::Long(*number)).unwrap();
assert_eq!(&encoded, hex_encoding);
}
}
Expand Down