Fix minor warnings from rust 1.66.0 #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> avro/tests/io.rs:135:64
|
135 | let encoded = to_avro_datum(&Schema::Long, Value::Long(*number as i64)).unwrap();
| ^^^^^^^^^^^^^^ help: try: `*number`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D clippy::all`
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
warning: unclosed HTML tag `Value`
--> avro/src/writer.rs:459:23
|
459 | /// Write the Into<Value> to the provided Write object. Returns a result with the number
| ^^^^^^^
|
= note: `#[warn(rustdoc::invalid_html_tags)]` on by default
help: try marking as source code
|
459 | /// Write the `Into<Value>` to the provided Write object. Returns a result with the number
| + +
warning: `apache-avro` (lib doc) generated 1 warning
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
…g a PR Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
added a commit
that referenced
this pull request
Dec 16, 2022
* Fix lint error in IT test
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> avro/tests/io.rs:135:64
|
135 | let encoded = to_avro_datum(&Schema::Long, Value::Long(*number as i64)).unwrap();
| ^^^^^^^^^^^^^^ help: try: `*number`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D clippy::all`
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
* Fix lint warning in rustdoc
warning: unclosed HTML tag `Value`
--> avro/src/writer.rs:459:23
|
459 | /// Write the Into<Value> to the provided Write object. Returns a result with the number
| ^^^^^^^
|
= note: `#[warn(rustdoc::invalid_html_tags)]` on by default
help: try marking as source code
|
459 | /// Write the `Into<Value>` to the provided Write object. Returns a result with the number
| + +
warning: `apache-avro` (lib doc) generated 1 warning
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
* Remove a non-existing label that dependabot tries to set when creating a PR
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
(cherry picked from commit 5016cd5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No JIRA ticket!
What is the purpose of the change
This PR fixes minor lint warnings produced by Rust 1.66.0.
Verifying this change
CI should pass!
Documentation