AVRO-3691:[maven build]Add nondex:2.1.1 to maven build section #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clesaec
approved these changes
Dec 21, 2022
Contributor
clesaec
left a comment
clesaec
left a comment
There was a problem hiding this comment.
LGTM : a new quality check tools is nice.
martin-g
requested changes
Jan 3, 2023
Member
martin-g
left a comment
martin-g
left a comment
There was a problem hiding this comment.
IMO this to be useful we should add edu.illinois:nondex-maven-plugin:2.1.1:nondex to the mvn ... call in the Github Actions Java workflow
Contributor
Author
|
Hi @martin-g. Thanks for your suggestion. I have created a new GitHub action workflow for Nondex. |
Member
|
@Jinzhengxu I am afraid the PR could not be merged until all tests pass successfully. |
Contributor
|
The issue comes from that the tested java class "Company" use HashMap, which does not guaranted to keep insert ordering. So replacing HashMap by LinkedHashMap (and same for caller) should solve it (and this also shows utility of nondex which found a bug in unit test code :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Nondex is a tool that helps improve the reliability and security of Java applications by detecting and eliminating nondeterministic behavior. This is accomplished through a combination of static analysis, runtime instrumentation, and data collection.
One of the main advantages of using nondex is that it can help identify and fix issues that are difficult to reproduce and debug. It can also help prevent security vulnerabilities by identifying and eliminating potential exploits that rely on nondeterministic behavior.
The purpose of adding nondex to the maven build section is to allow developers to easily incorporate this tool into their build and testing process. This will help ensure that the application is as reliable and secure as possible, providing value to both developers and users.AVRO-3691
Run the
mvn nondex:nondexcommand can discover two flaky tests. These tests have now been fixed in PR AVRO-3690 and AVRO-3689.Run the command
mvn nondex:nondex -DnondexRuns=10, NonDex can found more flaky tests that were not detected by the initial run.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation