Skip to content

Conversation

@Jinzhengxu
Copy link
Contributor

What is the purpose of the change

This pull request fixes the flaky test 'testAnnotationMultiAvroMeta', which was causing issues with AVRO-3690.

Verifying this change

Run this maven command to reproduce the issue:

mvn -pl lang/java/avro  edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.avro.reflect.TestReflect#testMultipleFieldAliases

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the Java Pull Requests for Java binding label Dec 15, 2022
Copy link
Contributor

@clesaec clesaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clesaec clesaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsbasjes
Copy link
Contributor

@Jinzhengxu Can you please rebase this? Thanks.

@Jinzhengxu
Copy link
Contributor Author

@nielsbasjes Sure. I will rebase this ASAP.

@nielsbasjes nielsbasjes merged commit 30c4cbf into apache:master Feb 18, 2023
@nielsbasjes
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants